Skip to main content

Avoid Using Property Names with Spaces

By
This is one that I have to reiterate often in my advanced class. 

So I’m looking over the forums on PowerShell.com and I see an answer to a post that contains a custom object.  First of all, awesome.  This answer that was provided returned an object to the PowerShell Pipeline.  The problem that I have with it is the properties have spaces in the names.  This makes reusability of this code more difficult.  Let’s look at the code that was provided.

$pc = Get-Content -Path C:\ps\names.txt
$results = @()
$results = foreach ($machine in $pc) {
    $computerName = (Get-WMIObject -class Win32_ComputerSystem -computername $machine).name
    $osInfo= Get-WMIObject -Class Win32_Operatingsystem -ComputerName $machine
    $getip = ([version](Test-Connection $machine -Count 1).IPV4Address.IPAddressToString).Build
    $desc = (Get-ADComputer $machine -Properties Description).description
    $ie = (Get-Command "\\$machine\c$\Program Files\Internet Explorer\iexplore.exe").Version

    [PSCustomObject]@{
    PCName = $computerName
    'OS Version' = $osInfo.Version
    'OS Type' = $osInfo.Caption
    'AD Description' = $desc
    'IP vLan' = $getip
    'IE Version' = $ie

    }
}
$results | export-csv -Path c:\ps\test1.csv

Again, this is not my code so it may look different with how I usually write.  Let’s read the results with Import-CSV.
PS C:\ps> Import-Csv -Path C:\ps\test1.csv


PCName         : LON-CL1
OS Version     : 10.0.10240
OS Type        : Microsoft Windows 10 Enterprise 2015 LTSB Evaluation
AD Description :
IP vLan        : 1
IE Version     : 11.0.10240.16384

Things do not really look all that bad.  The properties are very readable.  Now let’s pipe this object and use it.

Import-Csv -Path C:\ps\test1.csv |
    Select-Object -ExpandProperty OS Version

Select-Object : Property "OS" cannot be found.
At line:2 char:5
+     Select-Object -ExpandPropert OS Version
+     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : InvalidArgument: (@{PCName=LON-CL....0.10240.16384}:PSObject) [Select-Object], PSArgumentException
    + FullyQualifiedErrorId : ExpandPropertyNotFound,Microsoft.PowerShell.Commands.SelectObjectCommand

PowerShell is looking for a property called “OS”, not “OS Version”.  Remember that a space in a PowerShell command line is actually the delimiter between elements of the command.   You are actually try to pass “Version” as a positional parameter.  That is not going to work.

To fix this, you have to use the curly braces.
Import-Csv -Path C:\ps\test1.csv |
    Select-Object -ExpandProperty {OS Version}

PS C:\ps> Import-Csv -Path C:\ps\test1.csv |
    Select-Object -ExpandProperty {OS Version}

10.0.10240
10.0.10240
10.0.10240

When I receive information from a source that uses spaces, I immediately pipe the information to Select-Object and get rid of the spaces.  This allows me to code without adding the extra curly braces into my code while the object is in the pipeline.

Import-Csv -Path C:\ps\test1.csv |
    Select-Object -Property PCName,
        @{N = 'OSVersion' ; E = {$_.{OS Version}}},
        @{N = 'OSType' ; E = {$_.{OS Type}}},
        @{N = 'ADDescription' ; E = {$_.{AD Description}}},
        @{N = 'IPvLan' ; E = {$_.{IP vLan}}},
        @{N = 'IEVersion' ; E = {$_.{IE Version}}}

PCName        : LON-CL1
OSVersion     : 10.0.10240
OSType        : Microsoft Windows 10 Enterprise 2015 LTSB Evaluation
ADDescription :
IPvLan        : 1
IEVersion     : 11.0.10240.16384

Now moving forward, I do not need to add any extra curly braces.



Labels:

Comments

Post a Comment

Popular posts from this blog

Sticky Key problem between Windows Server 2012 and LogMeIn

By
This week I instructed my first class using Windows Server 2012 accessed via LogMeIn and discovered a Sticky Key problem every time you press the Shift key. Here is my solution to resolve this.  First off, in the Preferences of LogMeIn for the connection to the Windows Server, click General . Change the Keyboard and mouse priority to Host side user and click Apply at the bottom. On the Windows 2012 server, open the Control Panel – Ease of Access – Change how your keyboard works . Uncheck Turn on Sticky Keys . Click Set up Sticky Keys . Uncheck Turn on Sticky Keys when SHIFT is pressed five times . Click OK twice. If you are using Windows Server 2012 as a Hyper-V host, you will need to redo the Easy of Use settings on each guest operating system in order to avoid the Sticky Key Problem. Updated Information: March 20, 2013 If you continue to have problems, Uncheck Turn on Filter Keys .
6 comments
Read more

With the AD Recycle Bin Turned on, What Happens when you Create a User Account with a Password that does not meet the Password Policy?

By
This was an interesting observation from one of my Windows Server 2012 classes.  While working with the AD Recycle bin in a lab, one of my students discovered some interesting accounts that were created. When he created user accounts that did not meet password complexity requirements, an account is temporarily made and then deleted.  When a new password is provided that meets the password requirements, then a new account is made. We discovered this in two places.  First off in the Active Directory Administrative Center.  This is what caused the initial confusion.  Take a look.  This is in the Deleted Objects OU. You can see multiple deleted accounts for Test2 and one for Test3.  Test3 is a valid, functioning user account.  Using the PowerShell command Get-ADObject –IncludeDeletedObjects –Filter * –Properties ObjectSID we can see that indeed, two accounts were created, with one of them deleted. Notice the RID portion of the SID is different. ...
Post a Comment
Read more

Where did a User’s Account Get Locked Out?

By
Updated: May 15, 2015 When this article was originally published, two extra carriage returns were add causing the code to malfunction.  The code below is correct.   My client for this week’s PowerShell class had a really interesting question. They needed to know where an account is being locked out at. OK, interesting. Apparently users hop around clients and forget to log off, leading to eventual lock out of their accounts. The accounts can be unlocked, but are then relocked after Active Directory replication. This problem is solved in two parts. The first one is to modify the event auditing on the network. The second part is resolved with PowerShell. The first part involves creating a group policy that will encompass your Domain Controllers. In this GPO, make these changes. Expand Computer Configuration \ Policies \ Windows Settings \ Security Settings \ Advanced Audit Policy Configuration \ Audit Policies \ Account Management Double click User Account Management C...
18 comments
Read more